Stop supporting extra-files in favour of extra-sources

[kit-ty-kate]

It's a long term feature request but it looks to me that extra-source(s) is just a superset of extra-files with the added advantage of making repositories more lean and extremely easy to parse (if support for the opam 1.x repository format were also to be dropped)

One inconvenient is that it forces patches to be hosted somewhere else, but e.g. for opam-repository they could be hosted on https://github.com/ocaml/opam-source-archives/ instead for example.

[jonahbeckford]

How will this work with my Windows packages like https://github.com/diskuv/diskuv-opam-repository/blob/231969744fdeb1e76f2f850079c3e0f0fd94fc1c/packages/conf-sqlite3/conf-sqlite3.3.1%2Bcpkgs/opam#L58-L65 ?

[kit-ty-kate]

the same way. As far as i can see this package doesn't use extra-files

[jonahbeckford]

I'm a dork. Mentally saw extra-files as extra-sources. I stopped using those as it was easier to use git branches as you have already mentioned.

Ignore my lack of coffee!

[kit-ty-kate]

Side note for possible future implementers: We only depend on the base64 library to encode extra-files. Removing them would also remove the dependency.

[hannesm]

Side note: (a) this would be amazing for conex (security of opam-repository) as well, since its logic would be way smaller

and (b) in hannesm@900604d#diff-b5258ffa9cf2915b2fe0d75226f4e243d47b8de4fdbaa1405c12ccf220f9f126 I developed an opam admin subcommand to migrate existing opam files with extra-files to extra-sources.

for the main opam-repository, I also opened an issue proposing to apply this ocaml/opam-repository#25876