Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server pages from the server #101

Merged
merged 1 commit into from Sep 17, 2021
Merged

Server pages from the server #101

merged 1 commit into from Sep 17, 2021

Conversation

tmattio
Copy link
Collaborator

@tmattio tmattio commented Sep 17, 2021

This PR aligns the various HTML generation technologies used in the v3.ocaml.org site into a single server and monorepo. Previously, we had four different stacks while pulling together the unified site design:

  • ReScript/NextJS for static HTML
  • odoc+Tailwind output for static docs
  • opam2web for static package information
  • Dream+styling for the documentation browser

As we move towards a more feature-complete v3 site, all of these are now consolidated under the Dream-based web server, with a single set of OCaml source code that provides the templating logic for all portions of the site. Previously, the Tailwind logic was spread among multiple tools (odoc/opam2web/nextjs) and languages (ReScript/OCaml) and difficult to keep unified across the site.

There are several features that would benefit from ReScript (primarily those that require complex interactivity such as playgrounds) which we would like to revisit in v4 of the site. We've taken the decision to consolidate around OCaml for this iteration of the site, and come back to the more ambitious plans next year once v3 goes live. This PR maintains all of the commit histories of the ReScript site and bindings so that it can be brought back later.

Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
Copy link
Member

@avsm avsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avsm avsm merged commit 3ac61bc into main Sep 17, 2021
@tmattio tmattio deleted the ssr branch September 20, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants