typedef support (Closes #135) #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve the view type formatter when projecting types. Also introduce a convenience wrapper that just typedefs. With these changes it is possible to support "anonymous" types in C stubs as in issue #135, for example given: typedef struct { ... } SDL_JoystickGUID let joystick_guid : joystick_guid typ = structure "_SDL_JoystickGUID" (* ... *) let joystick_guid = typedef "SDL_JoystickGUID" joystick_guid let joystick_get_guid_string = foreign "SDL_JoystickGetGUIDString" (joystick_guid @-> ptr char @-> int @-> returning void) Ctypes should generate 'SDL_JoystickGUID x1696 = ...' instead of 'struct _SDL_JoystickGUID x1696 = ...' which would fail to compile.
|
This looks good to me. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve the view type formatter when projecting types.
Also introduce a convenience wrapper that just typedefs.
With these changes it is possible to support "anonymous" types in C stubs
as in issue #135, for example given:
typedef struct { ... } SDL_JoystickGUID
let joystick_guid : joystick_guid typ = structure "_SDL_JoystickGUID"
(* ... *)
let joystick_guid =
typedef "SDL_JoystickGUID" joystick_guid
let joystick_get_guid_string =
foreign "SDL_JoystickGetGUIDString"
(joystick_guid @-> ptr char @-> int @-> returning void)
Ctypes should generate 'SDL_JoystickGUID x1696 = ...' instead of
'struct _SDL_JoystickGUID x1696 = ...' which would fail to compile.