Update to OCaml 5.0 implementation of effects #7
Conversation
Still a few sections like the GDB one that could use some work, but this is good enough to release in my opinion
|
Two things I'm worried about:
|
|
Hi @tanelso2. Thanks for the work! It looks good to me overall.
That seems fine to me.
We've simplified the implementation of effect handlers and the gdb support. Hence, the changes are expected. |
|
Perhaps @Sudha247 may also have a look at this PR. |
| An effect system for OCaml | ||
| [is in development](https://www.youtube.com/watch?t=2035&v=z8SI7WBtlcA&feature=youtu.be). |
There was a problem hiding this comment.
If this is aimed at being a tutorial for the initial release of effects, does it still make sense to say it is "in development"?
It seems out of place and doesn't flow well
| ## 2. Effectful Computations in a Pure Setting | ||
| ## 2. Shallow vs Deep Handlers | ||
|
|
||
| The OCaml standard library provides two different modules for handling effects: `Effect.Deep` and `Effect.Shallow`. When a deep handler returns a continuation, the continuation also includes the handler. This means that, when the continuation is resumed, the effect handler is automatically re-installed, and will handle the effect(s) that the computation may perform in the future. |
There was a problem hiding this comment.
I wish we hadn't named the module Effect.Shallow as the handler therein are not shallow. Genuine shallow handlers are more expressive in a certain sense than the (sheep) handlers exposed by that module. I guess it is too late to make this change upstream @kayceesrk.
There was a problem hiding this comment.
Naming things is hard. Would you call these Sheep handlers rather than Shallow handlers? In any case, it may be useful to create an issue on ocaml/ocaml with a justification for why Shallow handlers may not be the most appropriate name.
There was a problem hiding this comment.
Can someone link me something on the difference between shallow and sheep handlers? I had trouble finding any information on this with Google, not sure where I should be looking
|
GitHub Actions job passed: https://github.com/tanelso2/ocaml-effects-tutorial/actions/runs/3476866298. It doesn't show up on the PR, I think it will be activated if the PR is merged. The outstanding comments have been addressed. |
|
If there are no further outstanding comments, feel free to merge @Sudha247 |
|
Thanks again @tanelso2! |
|
@Sudha247 Happy to help! Been really excited about algebraic effects as a concept and wanted to learn how to use them |
No description provided.