-
-
Notifications
You must be signed in to change notification settings - Fork 9
Move back to canonical isomorphic-git #36
Comments
@crutchcorn The second PR of yours was merged, but unfortunately into As an aside, I'm using patch-package to fix the issue in my repo. |
@chmac I honestly have no idea how I missed this comment from you. I appreciate you opening a new PR to migrate those things for us! FWIW, instead of using https://github.com/oceanbit-dev/GitShark/blob/main/package.json#L43 Also worth noting: We've migrated away from |
@crutchcorn Ahh yes, I see. You forked the package, then presumably you run Any plans to extract your git stuff into a separate package. I'm quite heavily invested in isomorphic-git in react-native, and reading about your memory problems was quite worrying! Would be great to see a react-native friendly git implementation out there. |
Actually, I'd be happy to migrate my Git codebase to a dedicated RN package once we have more work done on it. You can see the work I've done on the Android side (which is stable for my current usage): https://github.com/oceanbit/GitShark/tree/main/android/app/src/main/java/dev/oceanbit/gitshark/Git
But I am also working on iOS versions right now, based on Objective-Git: https://github.com/oceanbit/GitShark/blob/main/ios/GitModule.m (I have another few branches that are working on adding more features) I'd love to talk with you more about what you're using Git for with React Native! Would you be willing to drop me a line on Twitter: https://twitter.com/crutchcorn Or, if you'd rather, I'm also on Discord via a coding community I maintain: https://discord.gg/FMcvc6T I'd love to see ways that we can collaborate, share some of the stories I've run into trying to get everything working, see what your project is, etc! :D |
I'm going to close this issue, as I'm realizing that migration to upstream That said, @chmac please don't feel like you can't comment more here (or, like I'd mentioned, joining one of those links to talk more in a more reflective real-time environment) |
Currently, we have migrated to using a fork of isomorphic-git with the build artifacts published to a branch. This is due to the lack of the following PRs being merged:
We're currently waiting on these being merged upstream before we're able to move back to stable
The text was updated successfully, but these errors were encountered: