Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

aquarius.url / AQUARIUS_URL not used by Brizo so remove those from config settings? #43

Closed
ttmc opened this issue Dec 14, 2018 · 1 comment

Comments

@ttmc
Copy link
Contributor

ttmc commented Dec 14, 2018

Brizo doesn't need to know aquarius.url or AQUARIUS_URL. For proof, just do a search for the string aquarius in this repository. You won't find any Brizo source code that refers to aquarius anything.

If a Squid library needs aquarius.url or AQUARIUS_URL, then users of that Squid library should set it, not Brizo.

Conceptually, the reason Brizo doesn't need to know about one specific Aquarius instance is that it might be associated with many Aquarius instances. Why? Brizo is for publishers, and there might be many different marketplaces listing a publisher's assets.

eruizgar91 pushed a commit that referenced this issue Dec 14, 2018
eruizgar91 added a commit that referenced this issue Dec 14, 2018
@eruizgar91
Copy link
Contributor

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants