Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FixedRate: getBTSupply fails if basetoken contract does not exists #718

Closed
alexcos20 opened this issue Oct 13, 2022 · 1 comment · Fixed by #832
Closed

FixedRate: getBTSupply fails if basetoken contract does not exists #718

alexcos20 opened this issue Oct 13, 2022 · 1 comment · Fixed by #832
Assignees
@alexcos20
Labels
Priority: High Type: Bug Something isn't working
Milestone
Contracts v2.0.0

Comments

@alexcos20
Copy link
Member

https://github.com/oceanprotocol/contracts/blob/main/contracts/pools/fixedRate/FixedRateExchange.sol#L862

Test: https://goerli.etherscan.io/address/0xc313e19146fc9a04470689c9d41a4d3054693531#readContract and use 0xCBFDAC464E43F9EC83EB74CFE5C2E72B00B9CD869F473818578BDC0DDE2611B0 as exchangeID

Exchange was created in https://goerli.etherscan.io/tx/0xce43ff6a01a90471e988fedd4bf01e87e24803c3ae62ec8713b3b8371eb00246#eventlog
@alexcos20 alexcos20 added Type: Bug Something isn't working Priority: High labels Oct 13, 2022
@alexcos20 alexcos20 self-assigned this Oct 13, 2022
@alexcos20 alexcos20 added this to the v2.0.0 milestone Jul 27, 2023
@mihaisc
Copy link
Contributor

mihaisc commented Sep 24, 2023

@alexcos20 status?

@alexcos20 alexcos20 mentioned this issue Oct 25, 2023
Merged
@alexcos20 alexcos20 linked a pull request Oct 25, 2023 that will close this issue
check if basetoken is contract #832
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcos20 alexcos20

Labels
Priority: High Type: Bug Something isn't working
Projects
None yet
Milestone
Contracts v2.0.0
Development

Successfully merging a pull request may close this issue.

check if basetoken is contract oceanprotocol/contracts
2 participants
@alexcos20 @mihaisc