Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRE2.0: Remove owner transfer of baseTokens on sellDT #773

Closed
2 tasks done
alexcos20 opened this issue Jul 27, 2023 · 2 comments · Fixed by #778
Closed
2 tasks done

FRE2.0: Remove owner transfer of baseTokens on sellDT #773

alexcos20 opened this issue Jul 27, 2023 · 2 comments · Fixed by #778
Assignees
@alexcos20
Labels
Type: Enhancement New feature or request
Milestone
Contracts v2.0.0

Comments

@alexcos20
Copy link
Member

alexcos20 commented Jul 27, 2023 •
edited
Loading

see https://github.com/oceanprotocol/privateissues/issues/74

To Do:

  • Update contract
  • Update tests
@alexcos20 alexcos20 added the Type: Enhancement New feature or request label Jul 27, 2023
@alexcos20 alexcos20 self-assigned this Jul 27, 2023
@alexcos20 alexcos20 added this to the v2.0.0 milestone Jul 27, 2023
@alexcos20 alexcos20 mentioned this issue Jul 27, 2023
Merged
@alexcos20 alexcos20 linked a pull request Jul 27, 2023 that will close this issue
Remove owner transfer of baseTokens on sellDT #778
Merged
@mihaisc
Copy link
Contributor

mihaisc commented Sep 24, 2023

@alexcos20 status on this?

@alexcos20
Copy link
Member Author

closing this, since tests were added: https://github.com/oceanprotocol/contracts/blob/v2.0/test/flow/FixedRateExchange.test.js#L4346

@alexcos20 alexcos20 reopened this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcos20 alexcos20

Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
Contracts v2.0.0
Development

Successfully merging a pull request may close this issue.

Remove owner transfer of baseTokens on sellDT oceanprotocol/contracts
2 participants
@alexcos20 @mihaisc