balance pool setup #154
Merged
balance pool setup #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x3bfc
added
Status: DoNotMerge
0x3bfc
added
Feature
and removed
Status: DoNotMerge
ssallam
reviewed
Aug 14, 2020
ssallam
reviewed
Aug 14, 2020
ssallam
reviewed
Aug 14, 2020
done |
ssallam
reviewed
Aug 17, 2020
| @@ -146,6 +146,34 @@ contract SPool is BToken, BMath { | |||
| initialized = true; | |||
| return initialized; | |||
| } | |||
|
|
|||
| function setup( | |||
There was a problem hiding this comment.
this should only be callable by the controller.
There was a problem hiding this comment.
i guess this is implicit because it is using setSwapFee and finalize which both require sender == controller. so this is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #140