Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration setting to allow all users to save powerviews #1

Closed
danmihaila opened this issue Apr 25, 2016 · 4 comments
Closed

Configuration setting to allow all users to save powerviews #1

danmihaila opened this issue Apr 25, 2016 · 4 comments
Assignees

Comments

@danmihaila
Copy link

Implement a configuration setting that could allow users to save powerviews. The default behaviour is that only sysadmins can save a powerview

@brew
Copy link
Contributor

brew commented May 6, 2016

PowerView created_by checks against context user:

  • Auth for powerview_create (user must be authed for resource) (& tests)
  • Auth for powerview_update (user must be authed for resource) (& tests)
  • Auth for powerview_delete (& tests)
  • Auth for powerview_add_resource (user must be authed for resource) (& tests)
  • Auth for powerview_remove_resource (& tests)

@brew
Copy link
Contributor

brew commented May 9, 2016

See commit 15e17f6 for create, update and delete actions.

@brew
Copy link
Contributor

brew commented May 9, 2016

See commit bb8eff5 for add_resource and remove_resource action auth.

@brew
Copy link
Contributor

brew commented May 9, 2016

@danmihaila This is now done!

@brew brew closed this as completed May 9, 2016
brew added a commit that referenced this issue May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants