Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot link ESM plugins into CJS plugins #746

Closed
mdonnalley opened this issue Jul 26, 2023 · 2 comments
Closed

Cannot link ESM plugins into CJS plugins #746

mdonnalley opened this issue Jul 26, 2023 · 2 comments
Labels
bug Something isn't working ESM Related to ESM support

Comments

@mdonnalley
Copy link
Contributor

mdonnalley commented Jul 26, 2023

Describe the bug

You are not able to install or link ESM plugins into a CJS CLI

Actual Behavior

~/code/esm-cli » ~/code/node14-cli/bin/dev plugins link
Linking plugin ....
(node:66140) [ERR_UNKNOWN_FILE_EXTENSION] TypeError Plugin: esm-cli [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /Users/mdonnalley/code/esm-cli/src/commands/test.ts
module: @oclif/core@2.9.4
task: toCached
plugin: esm-cli
root: /Users/mdonnalley/code/esm-cli
See more details with DEBUG=*
(Use `node --trace-warnings ...` to show where the warning was created)
(node:66140) [ERR_UNKNOWN_FILE_EXTENSION] TypeError Plugin: esm-cli [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /Users/mdonnalley/code/esm-cli/src/commands/hello/index.ts
module: @oclif/core@2.9.4
task: toCached
plugin: esm-cli
root: /Users/mdonnalley/code/esm-cli
See more details with DEBUG=*
(node:66140) [ERR_UNKNOWN_FILE_EXTENSION] TypeError Plugin: esm-cli [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /Users/mdonnalley/code/esm-cli/src/commands/hello/world.ts
module: @oclif/core@2.9.4
task: toCached
plugin: esm-cli
root: /Users/mdonnalley/code/esm-cli
node14-cli: linking plugin esm-cli... done

Expected Behavior

No errors when linking ESM plugin to CJS plugin

@mdonnalley mdonnalley added the bug Something isn't working label Jul 26, 2023
@git2gus
Copy link

git2gus bot commented Jul 26, 2023

This issue has been linked to a new work item: W-13831264

@mdonnalley mdonnalley changed the title Mixing ESM and CJS plugins Cannot link ESM plugins into CJS plugins Jul 26, 2023
@mdonnalley mdonnalley added the ESM Related to ESM support label Jul 26, 2023
@mdonnalley
Copy link
Contributor Author

After deliberation with the team, we've decided that we are not going to support linking ESM plugins into CJS plugins. It's important to note that this only applies to linking plugins. Installing plugins in a production environment currently works and will continue to be supported.

@mdonnalley mdonnalley closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2023
@mdonnalley mdonnalley reopened this Aug 14, 2023
@mdonnalley mdonnalley mentioned this issue Aug 14, 2023
24 tasks
@mdonnalley mdonnalley closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ESM Related to ESM support
Projects
No open projects
Status: Closed
Development

No branches or pull requests

1 participant