Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

fix: allow custom git domains #81

Merged
merged 2 commits into from Jan 10, 2019
Merged

fix: allow custom git domains #81

merged 2 commits into from Jan 10, 2019

Conversation

koshilki
Copy link
Contributor

@koshilki koshilki commented Jan 3, 2019

Fix for #80

@salesforce-cla
Copy link

salesforce-cla bot commented Jan 3, 2019

Thanks for the contribution! Before we can merge this, we need @koshilki to sign the Salesforce.com Contributor License Agreement.

@jdx
Copy link
Contributor

jdx commented Jan 3, 2019

those URLs won't necessarily work on any host so it's better to not display anything than show a broken link

@koshilki
Copy link
Contributor Author

koshilki commented Jan 4, 2019

Thanks for reply, @jdxcode!
I believe URLs would work in most cases, especially using repositoryPrefix configuration, where you can override URL template.
Maybe, as a compromise, we can assume that if repositoryPrefix is present, it means developer knows what he or she is doing, and display link regardless if it's github, gitlab or whatever?
If that's okay, I'll update PR

@jdx
Copy link
Contributor

jdx commented Jan 4, 2019

I'm happy with adding repositoryPrefix as an optional config. I think that's a great solution

@koshilki
Copy link
Contributor Author

koshilki commented Jan 9, 2019

@jdxcode, sorry for a late reaction! I pushed new change to this PR, please take a look

@jdx
Copy link
Contributor

jdx commented Jan 10, 2019

nice job! thanks!

@jdx jdx merged commit 37e28d9 into oclif:master Jan 10, 2019
@rhwood
Copy link

rhwood commented Feb 18, 2019

Is there a sense of when this will be released?

I have a Lerna-based project where the links are all incorrect because oclif-dev readme assumes its running in the root of the git working copy, but its actually running in a subdirectory. It seems to me that the repositoryPrefix config would solve my problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants