This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
Configure S3 endpoint from env variable #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @michaeldwan to sign the Salesforce.com Contributor License Agreement. |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 35.4% 36.16% +0.75%
==========================================
Files 19 18 -1
Lines 692 636 -56
Branches 120 113 -7
==========================================
- Hits 245 230 -15
+ Misses 418 377 -41
Partials 29 29
Continue to review full report at Codecov.
|
jdx
reviewed
Mar 28, 2019
| return cache.s3 = cache.s3 || new (require('aws-sdk/clients/s3') as typeof S3)(this.creds) | ||
| return cache.s3 = cache.s3 || new (require('aws-sdk/clients/s3') as typeof S3)({ | ||
| ...this.creds, | ||
| endpoint: process.env.AWS_S3_ENDPOINT, |
There was a problem hiding this comment.
couldn't this just go on line 26?
There was a problem hiding this comment.
Ideally yeah, but this.creds is also passed to the CloudFront constructor on line 43 and CloudFront also accepts an endpoint option that we wouldn't want to set.
jdx
approved these changes
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets you publish to any S3 compatible host (eg DigitalOcean Spaces) using
AWS_S3_ENDPOINT. Existing behavior remains the same if unset.