Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Invalid bash variable #427

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Conversation

rsuarezmule
Copy link
Contributor

Hi team!
I'm from anypoint-cli team and need your approval for this PR

this change fixes the following issue:
#176

Previous behavior:

the environment variables such as oclif-cli-example was generated OCLIF_CLI-EXAMPLE, only replacing the first dash

Current behavior:

the environment variables with more than one dash for instance oclif-cli-example was generated OCLIF_CLI_EXAMPLE, replacing all the dashes in the string

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @rsuarezmule to sign the Salesforce.com Contributor License Agreement.

@git2gus
Copy link

git2gus bot commented Feb 22, 2023

This issue has been linked to a new work item: W-12585978

Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good (also affects zsh but it doesn't support dashes in env vars too).

Left a suggestion improve UT without having to add new fixtures

@cristiand391 cristiand391 merged commit ac82017 into oclif:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants