Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wr/bin aliases #470

Merged
merged 8 commits into from
May 30, 2023
Merged

Wr/bin aliases #470

merged 8 commits into from
May 30, 2023

Conversation

WillieRuemmele
Copy link
Contributor

@WillieRuemmele WillieRuemmele commented May 26, 2023

@W-13104211@

adds to scripts to alias the binAliases to the bins
adds bash script UT

testing helpful tips:
bash:
complete -r will turn off autocomplete for that session, double check it's not enabled for both CLI before testing

zsh:
delete the sf/sfdx paths in $fpath variable, delete the directories in ~/Library/caches/sf(dx)/autocomplete, double check autocomplete isn't working for both cli

@cristiand391 cristiand391 self-requested a review May 29, 2023 13:25
@cristiand391
Copy link
Member

QA notes:

previous steps:

# delete old autocomplete files for sf and sfdx:
rm -rf /Users/cdominguez/Library/Caches/sfdx/autocomplete/
rm -rf /Users/cdominguez/Library/Caches/sf/autocomplete

# use sf v2 with `sfdx` alias:
sf -v
@salesforce/cli/2.0.0-beta.43 darwin-x64 node-v18.12.1

# generete completion files
sf autocomplete

# reload shells/terminal

bin aliases zsh, bash & powershell (tested on macos)

✅ works for sf and sfdx, complete all sub-args and flags correctly

generate valid completion files for CLI without bin aliases

✅ all comp. functions still work on all shells

@cristiand391
Copy link
Member

QA notes:

pwsh (macos)

✅ completion is registered for both sf and sfdx correctly
✅ CLI without binAliases still get valid completion file.

@cristiand391 cristiand391 merged commit 9eb97a7 into main May 30, 2023
7 checks passed
@cristiand391 cristiand391 deleted the wr/binAliases branch May 30, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants