/
ObjCVerifyIsEqualHashRule.cpp
104 lines (82 loc) · 2.21 KB
/
ObjCVerifyIsEqualHashRule.cpp
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
#include <clang/AST/Attr.h>
#include "oclint/AbstractASTVisitorRule.h"
#include "oclint/RuleSet.h"
#include "oclint/helper/EnforceHelper.h"
#include "oclint/util/ASTUtil.h"
using namespace std;
using namespace clang;
using namespace oclint;
class ObjCVerifyIsEqualHashRule : public AbstractASTVisitorRule<ObjCVerifyIsEqualHashRule>
{
public:
virtual const string name() const override
{
return "missing hash method";
}
virtual int priority() const override
{
return 1;
}
virtual const string category() const override
{
return "cocoa";
}
virtual unsigned int supportedLanguages() const override
{
return LANG_OBJC;
}
#ifdef DOCGEN
virtual const std::string since() const override
{
return "0.8";
}
virtual const std::string description() const override
{
return "When ``isEqual`` method is overridden, ``hash`` method must be overridden, too.";
}
virtual const std::string fileName() const override
{
return "ObjCVerifyIsEqualHashRule.cpp";
}
virtual const std::string example() const override
{
return R"rst(
.. code-block:: objective-c
@implementation BaseObject
- (BOOL)isEqual:(id)obj {
return YES;
}
/*
- (int)hash is missing; If you override isEqual you must override hash too.
*/
@end
)rst";
}
#endif
bool VisitObjCImplementationDecl(ObjCImplementationDecl *implementation) {
bool foundHash = false;
bool foundIsEqual = false;
for (auto it = implementation->instmeth_begin(), ite = implementation->instmeth_end();
it != ite;
++it)
{
string name = (*it)->getNameAsString();
if (name == "hash")
{
foundHash = true;
}
if (name == "isEqual:")
{
foundIsEqual = true;
}
}
if (foundIsEqual && !foundHash)
{
addViolation(implementation,
this,
"If you override isEqual you must override hash too.");
}
return true;
}
};
static RuleSet rules(new ObjCVerifyIsEqualHashRule());