-
Notifications
You must be signed in to change notification settings - Fork 491
/
DefaultLabelNotLastInSwitchStatementRule.cpp
89 lines (74 loc) · 2.09 KB
/
DefaultLabelNotLastInSwitchStatementRule.cpp
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
#include "oclint/AbstractASTVisitorRule.h"
#include "oclint/RuleSet.h"
using namespace std;
using namespace clang;
using namespace oclint;
class DefaultLabelNotLastInSwitchStatementRule :
public AbstractASTVisitorRule<DefaultLabelNotLastInSwitchStatementRule>
{
public:
virtual const string name() const override
{
return "ill-placed default label in switch statement";
}
virtual const string identifier() const override
{
return "IllplacedDefaultLabel";
}
virtual int priority() const override
{
return 3;
}
virtual const string category() const override
{
return "convention";
}
#ifdef DOCGEN
virtual const std::string since() const override
{
return "0.6";
}
virtual const std::string description() const override
{
return "It is very confusing when default label is not the last label "
"in a switch statement.";
}
virtual const std::string fileName() const override
{
return "DefaultLabelNotLastInSwitchStatementRule.cpp";
}
virtual const std::string example() const override
{
return R"rst(
.. code-block:: cpp
void example(int a)
{
switch (a) {
case 1:
break;
default: // the default case should be last
break;
case 2:
break;
}
}
)rst";
}
#endif
bool VisitSwitchStmt(SwitchStmt *switchStmt)
{
// SwitchCaseList has a linked data structure in the reversed order
SwitchCase *currentSwitchCase = switchStmt->getSwitchCaseList();
while (currentSwitchCase && isa<CaseStmt>(currentSwitchCase))
{
SwitchCase *nextSwitchCase = currentSwitchCase->getNextSwitchCase();
if (nextSwitchCase && isa<DefaultStmt>(nextSwitchCase))
{
addViolation(nextSwitchCase, this);
}
currentSwitchCase = nextSwitchCase;
}
return true;
}
};
static RuleSet rules(new DefaultLabelNotLastInSwitchStatementRule());