Allow title, subject, author, and keywords to be unset with an empty string argument #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1059 +/- ##
==========================================
- Coverage 81.48% 80.24% -1.24%
==========================================
Files 75 75
Lines 6027 6035 +8
Branches 1131 1135 +4
==========================================
- Hits 4911 4843 -68
- Misses 939 1005 +66
- Partials 177 187 +10
|
|
Sorry for taking so long to get back. Could you add a test to confirm this change continues to work correctly? |
|
@jbarlow83 Please, no apologies. :) Your hard work and dedication is greatly appreciated. I noticed that this does remove the appropriate metadata from the DocumentInfo block but apparently leaves it in the XMP steam object. I'll work on fixing this and will also provide the requested tests. |
f-hansen
force-pushed
the
unset_metadata
branch
2 times, most recently
from
f31fb5f
to
2b777ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing --title='', --subject='', author='', or keywords='' is currently ignored. As a workaround, users tend to pass a space when they do not want such original metadata to carry forward. It is more desirable to be able to simply unset the output metadata rather than setting it to " ".