Improve PDF rasterisation safety #1083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required when rasterising certain PDFs. When missing GhostScript was outputting a blank page.
Without this option GhostScript will ignore errors when rasterising pages and cause OCRmyPDF to output corrupted files. With this option the error bubbles up and OCRmyPDF will fail.
|
Thanks very much for getting this into the codebase @jbarlow83 - much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #514 I stumbled across an issue where by a file processed by OCRmyPDF would result in corrupted output (some output pages would be blank where the input was not).
This PR makes a couple of changes to fix this and make the behaviour of OCRmyPDF generally safer:
fonts-droid-fallbackpackage to theDockerfileto ensure that GhostScript's fallback font is presentPDFSTOPONERRORoption to the GhostScript command when rasterising a page of a PDF so that OCRmyPDF fails fast rather than continuing and outputting a bad PDF