Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version in the 1.0.0 packaged releases #793

Closed
k2niner opened this issue Sep 27, 2023 · 4 comments
Closed

Wrong version in the 1.0.0 packaged releases #793

k2niner opened this issue Sep 27, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@k2niner
Copy link
Contributor

k2niner commented Sep 27, 2023

Releases here: https://github.com/ocsf/ocsf-schema/releases/tag/v1.0.0

contain the following version.json:

{
  "version": "1.0.0-rc.3"
}
@mikeradka
Copy link
Contributor

Nice catch here, @k2niner. Thanks for bringing it up in our sync yesterday. I don't think it is breaking for the creation of OCSF documents, but it may cause an issue when building a v1 server and could theoretically cause downstream issues for anyone utilizing that file.

@rmouritzen-splunk I looked at this a little bit, but am unsure of the best course of action. Since a tag is just a commit, I don't think it is as easy as just updating the version. If i understand, this could be immutable.

@mikeradka
Copy link
Contributor

mikeradka commented Sep 29, 2023

I looked at this once more. Perhaps there is still a way to approach this. Since there is also a v1 branch, and the v1 branch indeed has the correct version.json - I think we may be able to simply cut a fresh- v1.0.0 release from the v1.0.0 branch, and delete the old v1 tagged release.

We can try out a diff between the v1 branch and v1 tagged release - if this is the only difference, then I think we will be safe to delete the old v1 tagged commit and create a new one from the v1 branch.

@mikeradka
Copy link
Contributor

Update: Looks like there are only two very small non-breaking changes between this build - an attribute description, and the update of the version from rc3 to v1.0.0.

image image

For reference, this is the commit from where the old inaccurate release was cut: 6f73e0e

Here is the commit from which I created an accurate v1.0.0 release: 9608805

@mikeradka
Copy link
Contributor

The v1 release has been tested, verified, and updated. Here is the link: https://github.com/ocsf/ocsf-schema/releases/tag/v1.0.0

@mikeradka mikeradka self-assigned this Sep 29, 2023
@mikeradka mikeradka added the bug Something isn't working label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants