Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dialog boxes #63

Open
sffc opened this issue Dec 12, 2021 · 1 comment
Open

Add support for dialog boxes #63

sffc opened this issue Dec 12, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sffc
Copy link
Contributor

sffc commented Dec 12, 2021

Octave has functions to display dialog boxes to the user, such as listdlg and msgbox. We should support these dialog boxes in Octave Online.

The dialog box events are plumbed into the interpreter_events API in Octave, so implementing this ticket means:

  1. Write the HTML/CSS/JavaScript for each type of dialog box
  2. Add support for the dialog boxes to octave_json_link in the Octave Online patch
  3. Send messages for dialog boxes through the stack so that when octave_json_link receives a dialog box event, that event is forwarded to the client where the HTML/CSS/JavaScript can appear

This is a good first issue because the implementation is straightforward, but note that it requires being familiar with multiple parts of the stack (with an emphasis on the client and octave_json_link).

@sffc sffc added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 12, 2021
@sffc
Copy link
Contributor Author

sffc commented Jan 2, 2023

Note: currently the octave_json_link event manager returns true for dialog support, since that component does support them, but the Octave Online part does not do anything with the dialog messages.

https://hg.octave.org/octave/rev/a7981aa5822b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant