review(JOB-135): Renames computed attribute and ajusts css

octo-webf · Oct 13, 2017 · d6a84c1 · d6a84c1
1 parent 952fb71
commit d6a84c1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/client/src/components/InterestModal.vue b/client/src/components/InterestModal.vue
@@ -4,8 +4,8 @@
 
       <!-- modal header-->
       <div class="interest-modal__header">
-        <h2 class="interest-modal__title">Intéressé·e&nbsp; par <strong>{{ mission }}</strong> pour <strong>{{ customer }}</strong>&nbsp;?</h2>
-        <button class="interest-modal__action interest-modal__action--cancel" @click="cancelInterest"><icon name="times" scale="1.5"></icon></button>
+        <h2 class="interest-modal__title">Intéressé·e&nbsp; par <strong>{{ mission }}</strong> pour <strong>{{ customerName }}</strong>&nbsp;?</h2>
+        <button class="interest-modal__action interest-modal__action--cancel" @click="_closeModal"><icon name="times" scale="1.5"></icon></button>
       </div>
 
       <!-- modal body -->
@@ -25,7 +25,7 @@
                   @click="submitInterest">Je suis disponible
           </button>
         </div>
-        <p class="interest-modal__mentions interest-modal__text">L'équipe Job Board te mettra en relation avec <strong>{{ missionDirectorNickname }}</strong> , dir. mission et <strong>{{ businessContactNickname }}</strong>, contact biz.</p>
+        <p class="interest-modal__mentions">L'équipe Job Board te mettra en relation avec <strong>{{ missionDirectorNickname }}</strong> , dir. mission et <strong>{{ businessContactNickname }}</strong>, contact biz.</p>
       </div>
 
     </modal>
@@ -85,7 +85,7 @@
         return missionName.substring(0, 49);
       },
 
-      customer() {
+      customerName() {
         if (!this.interestingJob) return '';
         return (this.interestingJob.project.customer.name) ? this.interestingJob.project.customer.name : 'N/A';
       },
@@ -137,10 +137,6 @@
         this._removeError();
       },
 
-      cancelInterest() {
-        this._closeModal();
-      },
-
       _resetInterest() {
         this.interest = null;
       },
@@ -245,7 +241,11 @@
   }
 
   .interest-modal__mentions {
+    width: 100%;
+    resize: none;
+    overflow: auto;
     font-size: 14px;
+    box-sizing: border-box;
     font-style: italic;
     text-align: center;
   }

diff --git a/client/test/unit/specs/components/InterestModal.spec.js b/client/test/unit/specs/components/InterestModal.spec.js
@@ -240,13 +240,14 @@ describe('Unit | Component | InterestModal.vue', () => {
         // Then
         expect(missionName).to.equal('SCLOU - Cloud computing : enjeux, architecture et');
       });
+    });
 
-
-      it.only('should get customerName', () => {
+    describe('computed property #customerName', () => {
+      it('should get customerName', () => {
         // Given
 
         // When
-        const customerName = component.customer;
+        const customerName = component.customerName;
 
         // Then
         expect(customerName).to.equal('La Poste - Courrier');