Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refonte UX/UI de la page Jobs #106

Merged
merged 7 commits into from
Aug 25, 2017
Merged

Refonte UX/UI de la page Jobs #106

merged 7 commits into from
Aug 25, 2017

Conversation

jbuget
Copy link
Contributor

@jbuget jbuget commented Aug 23, 2017

Fixes #105

Cette refonte fait suite à une réflexion avec Jérémy Anneheim, @trollepierre et moi-même.

La maquette a été soumise pour bêta-test en avance de phase à une dizaine d'Octos et leurs retours pris en compte.

En particulier, les points importants qui reviennent "toujours" :

  1. quelle est le poste ?
  2. quelle sont les technos (en général ça apparaît dans le poste) ?
  3. qui est le client (d'où l'a mise en avant au détriment du titre de la mission) ?
  4. quel est le lieu ?
  5. quelle est la durée ? (ça on ne peut pas l'afficher car on n'a pas l'info [i.e. "les IA peuvent s'améliorer là-dessus"])

Par ailleurs, des infos supplémentaires sont désormais affichées :

  • la réf. mission
  • le contact business (toujours défini)
  • le contact directeur de mission, quand il est défini

Avant :

capture d ecran 2017-08-23 a 15 01 26

Après :

capture d ecran 2017-08-23 a 15 01 36

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.704% when pulling d58784c on redesign-job-card into 0101e29 on dev.

@trollepierre trollepierre self-requested a review August 24, 2017 11:58
Copy link
Collaborator

@trollepierre trollepierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code à nettoyer avant envoi de la feature


<!--
<div class="job__menu">
<icon name="ellipsis-h"></icon>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

<h3 class="job__customer">{{ job.project.customer.name }}</h3>
<h4 class="job__mission">{{ mission }}</h4>
</div>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pourquoi tant d'espaces ?

<div class="job__secondary">
<div class="job__meta-title">Mission</div>
<h3 class="job__mission">Refonte Explorimmo</h3>
<h4 class="job__client">Le Figaro Classifieds (filliale versée dans l'immo)</h4>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filiale

</div>
<div class="job__meta">
<div class="job__meta-title">Lieu(x)</div>
<div class="job__meta-value job__location">Paris 9e, Belgique?</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belgique ? (avec un espace entre les deux mots)

@@ -0,0 +1,192 @@
<template>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete it

.job__mission {
margin: 10px 0;
font-size: 1rem;
/*color: #5fba7d;*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete it

/* not used*/
.job__status--proposal_sent {
background: #6699FF;
.job__reference {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

/*color: #9199a1;*/
}

.job__nature {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete it

text-align: center;
padding: 15px;
border-top: 1px solid #e6e6e6;
border-top: 1px solid rgba(0, 0, 0, .05) !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pk important ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je ne connais plus la raison... mais une partie de la cause vient du fait que j'ai pompé le style sur StackOverflow/jobs ^^

@@ -4,13 +4,19 @@ import VueAnalytics from 'vue-analytics';
import JobCard from '@/components/JobCard';
import interestsApi from '@/api/interests';
import authenticationService from '@/services/authentication';
import Icon from 'vue-awesome/components/Icon';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

une seule ligne d'espace

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.704% when pulling 6fbb8b0 on redesign-job-card into 0101e29 on dev.

@jbuget jbuget merged commit 10a7324 into dev Aug 25, 2017
@jbuget jbuget deleted the redesign-job-card branch August 25, 2017 15:47
@jbuget jbuget restored the redesign-job-card branch August 25, 2017 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants