-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refonte UX/UI de la page Jobs #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code à nettoyer avant envoi de la feature
client/src/components/JobCard.vue
Outdated
|
||
<!-- | ||
<div class="job__menu"> | ||
<icon name="ellipsis-h"></icon> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
<h3 class="job__customer">{{ job.project.customer.name }}</h3> | ||
<h4 class="job__mission">{{ mission }}</h4> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pourquoi tant d'espaces ?
client/src/components/DesignPage.vue
Outdated
<div class="job__secondary"> | ||
<div class="job__meta-title">Mission</div> | ||
<h3 class="job__mission">Refonte Explorimmo</h3> | ||
<h4 class="job__client">Le Figaro Classifieds (filliale versée dans l'immo)</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filiale
client/src/components/DesignPage.vue
Outdated
</div> | ||
<div class="job__meta"> | ||
<div class="job__meta-title">Lieu(x)</div> | ||
<div class="job__meta-value job__location">Paris 9e, Belgique?</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belgique ? (avec un espace entre les deux mots)
client/src/components/DesignPage.vue
Outdated
@@ -0,0 +1,192 @@ | |||
<template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete it
client/src/components/JobCard.vue
Outdated
.job__mission { | ||
margin: 10px 0; | ||
font-size: 1rem; | ||
/*color: #5fba7d;*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete it
client/src/components/JobCard.vue
Outdated
/* not used*/ | ||
.job__status--proposal_sent { | ||
background: #6699FF; | ||
.job__reference { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used
client/src/components/JobCard.vue
Outdated
/*color: #9199a1;*/ | ||
} | ||
|
||
.job__nature { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete it
text-align: center; | ||
padding: 15px; | ||
border-top: 1px solid #e6e6e6; | ||
border-top: 1px solid rgba(0, 0, 0, .05) !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pk important ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je ne connais plus la raison... mais une partie de la cause vient du fait que j'ai pompé le style sur StackOverflow/jobs ^^
@@ -4,13 +4,19 @@ import VueAnalytics from 'vue-analytics'; | |||
import JobCard from '@/components/JobCard'; | |||
import interestsApi from '@/api/interests'; | |||
import authenticationService from '@/services/authentication'; | |||
import Icon from 'vue-awesome/components/Icon'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
une seule ligne d'espace
Fixes #105
Cette refonte fait suite à une réflexion avec Jérémy Anneheim, @trollepierre et moi-même.
La maquette a été soumise pour bêta-test en avance de phase à une dizaine d'Octos et leurs retours pris en compte.
En particulier, les points importants qui reviennent "toujours" :
Par ailleurs, des infos supplémentaires sont désormais affichées :
Avant :
Après :