Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaration of Illuminate\View\Factory::composer($views, $callback) must be compatible with Illuminate\Contracts\View\Factory::composer($views, $callback, $priority = NULL) #4009

Closed
bkrajendra opened this issue Dec 25, 2018 · 11 comments

Comments

@bkrajendra
Copy link

Just tried Updating my 443 ocms with latest 445 and Im getting error on update screen

Update failed
{ "message": "Declaration of Illuminate\\View\\Factory::composer($views, $callback) must be compatible with Illuminate\\Contracts\\View\\Factory::composer($views, $callback, $priority = NULL)", "exception": "Symfony\\Component\\Debug\\Exception\\FatalErrorException", "file": "/home/iocarein/public_html/vendor/laravel/framework/src/Illuminate/View/Factory.php", "line": 14, "trace": [] }

@w20k

This comment has been minimized.

@LukeTowers
Copy link
Contributor

@w20k this is unrelated to the other problem.

@bkrajendra what plugins do you have installed? This is occurring because you have multiple versions of Laravel included in your installation. The specific change that is throwing your error was laravel/framework@19fcecf and was a part of the 5.5 upgrade. The issue is probably coming from a plugin that has a vendor directory that includes one or more of Laravel's core packages at a version earlier than 5.5

@LukeTowers LukeTowers changed the title Updating 443 ocms with latest 445 getting error on update screen Declaration of Illuminate\\View\\Factory::composer($views, $callback) must be compatible with Illuminate\\Contracts\\View\\Factory::composer($views, $callback, $priority = NULL) Dec 26, 2018
@pbsmultimedia
Copy link

+1

@bkrajendra
Copy link
Author

As I have checked this related to few plugin that are using Laravel 5.5 or earlier.
vdomah-excel and eugenetolok-telegram are the affected plugins

I used simple technique on my production server without disturbing anything.
Moved all plugins to a folder outside octobercms then started copying each plugin folder one by one. and finally got hold of plugin that was throwing exception.

Little old school but solved my issue in few minutes.

@LukeTowers LukeTowers changed the title Declaration of Illuminate\\View\\Factory::composer($views, $callback) must be compatible with Illuminate\\Contracts\\View\\Factory::composer($views, $callback, $priority = NULL) Declaration of Illuminate\View\Factory::composer($views, $callback) must be compatible with Illuminate\Contracts\View\Factory::composer($views, $callback, $priority = NULL) Jan 7, 2019
@LukeTowers
Copy link
Contributor

@bkrajendra another person has reported issues with vdomah-excel, will look into solutions

@setianke
Copy link

@LukeTowers would like to report the issue oocures with nevets-paypalipn as well

@LukeTowers
Copy link
Contributor

@setianke report it to the plugin author and if they don't respond, send an email to hello@octobercms.com to have the plugin taken down.

@bennothommo
Copy link
Contributor

Closing as it has been over a month since any activity on this occurred and we are trying to figure out what issues are still relevant. If this is still something that you would like to see through to fruition please respond and we can get the ball rolling.

@flyingbaba
Copy link

  • 1

@LukeTowers
Copy link
Contributor

@flyingbaba

  • 2

@flyingbaba
Copy link

Ok, I wanted to just add +1 on that.
Had this issue, in my case the solution was to update third party service providers. Simply by running composer update in my plugin directory solved this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants