Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need a way to inject meta tags #45

Closed
daftspunk opened this issue May 12, 2014 · 7 comments
Closed

Need a way to inject meta tags #45

daftspunk opened this issue May 12, 2014 · 7 comments
Assignees
@daftspunk

Comments

@daftspunk
Copy link
Member

We have

{% scripts %}
{% styles %}

Need to have

{% meta %}

TBA
@ChadStrat
Copy link
Contributor

+1

@daftspunk daftspunk mentioned this issue May 13, 2014
Closed
@fuzenco
Copy link

fuzenco commented May 16, 2014

+1

@daftspunk daftspunk self-assigned this Jun 30, 2014
@ghost
Copy link

ghost commented Jul 1, 2014

+1

3 similar comments
@coderdiaz
Copy link

+1

@Shahiem
Copy link

Shahiem commented Jul 2, 2014

+1

@EHLOVader
Copy link

+1

@daftspunk
Copy link
Member Author

Although this seems reasonable, we discussed it and think the pipe for meta tags is too generic and magical. To avoid ending up like Wordpress, things that require meta tags (Google Analytics, etc) should use a component to remain explicit.

Or if absolutely necessary, it is safe to assume {% styles %} will be contained in the <head> section and {% scripts %} will be there too, or in the footer. These areas can have content injected in them...

{% puts scripts %}
<script> alert('Hey, guy!'); </script>
{% endput %}

@salehasadi salehasadi mentioned this issue Mar 1, 2017
Closed
@yangzhipeng yangzhipeng mentioned this issue Mar 3, 2017
Closed
@stevemortimer stevemortimer mentioned this issue Sep 7, 2017
Closed
@MyhedinZika MyhedinZika mentioned this issue Nov 8, 2017
Closed
@bekerov bekerov mentioned this issue Jan 7, 2018
Closed
@mattiak14 mattiak14 mentioned this issue Mar 1, 2018
Closed
@PowerChaos PowerChaos mentioned this issue Feb 18, 2019
Closed
@ghost ghost mentioned this issue Jul 26, 2020
Closed
@xyz1123581321 xyz1123581321 mentioned this issue Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daftspunk daftspunk

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fuzenco @EHLOVader @ChadStrat @daftspunk @coderdiaz @Shahiem