Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve paginate() method #5187

Closed
daftspunk opened this issue Mar 10, 2014 · 1 comment
Closed

Improve paginate() method #5187

daftspunk opened this issue Mar 10, 2014 · 1 comment

Comments

@daftspunk
Copy link
Member

It is unnatural to set the current pagination page by using:

App::make('paginator')->setCurrentPage(2);

We should include this as part of the ->paginate() method in the Model. Eg:

$model->paginate(<records per page>, <current page>, [...]);
@daftspunk
Copy link
Member Author

Done

@LukeTowers LukeTowers transferred this issue from octobercms/library Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daftspunk