Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay requests made by the markdown formwidget until the user stops typing momentarily #5523

Closed
multiwebinc opened this issue Mar 1, 2021 · 2 comments

Comments

@multiwebinc
Copy link
Contributor

  • OctoberCMS Build: 1.0.471

Description:

With the current markdown editor in split mode, a request is sent to the server for every single keystroke. This doesn't play well with DDoS prevention mechanisms, such as Apache's mod_evasive, which quickly causes a 403 error after just a few keystrokes. Would it be possible to use a client-side markdown parser, or at the very least throttle the number of requests sent to the server to something more sensible?

@LukeTowers
Copy link
Contributor

@multiwebinc it should be possible to throttle the requests after a given delay of no keystrokes, if that hasn't already been implemented (I seem to remember something similar being implemented, but I can't remember if it was specifically for the markdown widget or something like the search field).

@LukeTowers LukeTowers changed the title Markdown editor makes too many requests to the server Delay requests made by the markdown formwidget until the user stops typing momentarily Mar 1, 2021
@daftspunk
Copy link
Member

if that hasn't already been implemented

The logic only stops polling when an active request is being made, so if you have a low latency server it could get pinged quite often

This doesn't play well with DDoS prevention mechanisms

This issue has been addressed in the next version of October CMS. Stay tuned for the announcement!

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants