Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CombineAssets combine not working if there are several kubernetes pod #5750

Closed
aifst opened this issue Sep 6, 2023 · 2 comments
Closed

CombineAssets combine not working if there are several kubernetes pod #5750

aifst opened this issue Sep 6, 2023 · 2 comments

Comments

@aifst
Copy link

aifst commented Sep 6, 2023

version: v1.1.12
class: System\Classes\CombineAssets
method: prepareCombiner

is it possible to adapt part of the logic of the prepareCombiner method to use a different type of cache storage, better with the ability to specify type?

$cache = new FilesystemCache($this->storagePath);

instead something like

$cache = Cache::storage();

or

if (!$cache = Event::fire('cms.combiner.cachePrepare', [$this], true)) {
  $cache = new FilesystemCache($this->storagePath);
}
@daftspunk
Copy link
Member

Hi @aifst

We can add the event here, although development is now on v3.4, so for you the more significant issue may be upgrading to the latest version and working through the Laravel changes. In the October CMS space, there are minimal breaking changes from v1 to v3.

Closing since we are no longer adding features to v1, however, you may continue to reply here.

@daftspunk daftspunk closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
@aifst
Copy link
Author

aifst commented Sep 7, 2023

yes, we are planning a transition to 3.*, it would not be bad to add such an option there

Thank you very much for the prompt reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants