Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript): Add typings for the module #16

Merged
merged 5 commits into from
Jan 29, 2019
Merged

feat(typescript): Add typings for the module #16

merged 5 commits into from
Jan 29, 2019

Conversation

wolfy1339
Copy link
Member

No description provided.

@wolfy1339
Copy link
Member Author

This requires the @types\lru-cache for it to work. Where should it be added in package.json, dependencies or devDependencies?

gr2m
gr2m reviewed Jan 29, 2019
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts
@@ -0,0 +1,25 @@
import LRU = require("lru-cache");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should that be import LRU from 'lru-cache'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the TypeScript equivalent (it transpires down to) to CommonJS import syntax

gr2m and others added 3 commits January 29, 2019 00:19
@gr2m @wolfy1339
installation_id is a number
a1c8326 
Co-Authored-By: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
@gr2m @wolfy1339
Update index.d.ts
a6b1d8d 
Co-Authored-By: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
@wolfy1339
Mark functions as public and remove extraneous interface
01c4081
gr2m
gr2m approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gr2m gr2m merged commit 6dbc4c0 into octokit:master Jan 29, 2019
@gr2m
Copy link
Contributor

gr2m commented Jan 29, 2019

If you like, you can send a PR to probot@beta to use these typings now, instead of https://github.com/probot/probot/blob/beta/src/%40types/%40octokit/app/index.d.ts

@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wolfy1339 @gr2m @octokitbot