Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README #191

Closed
5 tasks
first-timers bot opened this issue Oct 15, 2020 · 15 comments
Closed
5 tasks

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README #191

first-timers bot opened this issue Oct 15, 2020 · 15 comments
Assignees
Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects

Comments

@first-timers
Copy link

first-timers bot commented Oct 15, 2020

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

The Pika CDN is now Skypack, see https://www.pika.dev/cdn. The CDN at https://cdn.pika.dev/ no longer works, all URLs must be replaced with the new CDN: https://cdn.skypack.dev/. We currently recommend using cdn.pika.dev to import the library into the browser, but that no longer works. Replacing it with cdn.skypack.dev will make it work again.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    More than one person can work on this issue, don't worry if it's already claimed.

  • πŸ“ Update the file \README.md (press the little pen Icon) and edit as shown below:

@@ -32,11 +32,11 @@ For other GitHub authentication strategies see [octokit/auth.js](https://github.
 Browsers
 </th><td width=100%>
 
-Load `@octokit/auth-app` directly from [cdn.pika.dev](https://cdn.pika.dev)
+Load `@octokit/auth-app` directly from [cdn.skypack.dev](https://cdn.skypack.dev)
 
 ```html
 <script type="module">
-  import { createAppAuth } from "https://cdn.pika.dev/@octokit/auth-app";
+  import { createAppAuth } from "https://cdn.skypack.dev/@octokit/auth-app";
 </script>
 ```
 
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

    1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
    2. You can edit files directly in your browser
  • 🏁 Done Ask for a review :)

If there are more than one pull requests with the correct change, we will merge the first one, but attribute the change to all authors who made the same change using @Co-authored-by, so yo can be sure your contribution will count.

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@ghost ghost added this to Inbox in JS Oct 15, 2020
@gr2m gr2m added Type: Bug Something isn't working as documented, or is being fixed documentation labels Oct 15, 2020
@ghost ghost moved this from Inbox to Bugs in JS Oct 15, 2020
@divinenaman
Copy link

Hey! can you let me fix this issue? This will be my first issue and hopefully this will break my bubble.

@wolfy1339
Copy link
Member

Sure thing! It's all yours

@gr2m gr2m linked a pull request Oct 17, 2020 that will close this issue
@archi15
Copy link

archi15 commented Oct 19, 2020

I'd would like to contribute in this. Will I?

@gr2m
Copy link
Contributor

gr2m commented Oct 19, 2020

Of course you can, @archi15 πŸ‘πŸΌ

@archi15
Copy link

archi15 commented Oct 19, 2020

I had made the changes. Please review my PR #194 . Thanks!

@jefferycline1
Copy link

That's cool sorry I been away and just got this.

@gr2m
Copy link
Contributor

gr2m commented Oct 20, 2020

@jefferycline1 would you like to send a pull request for this issue? Follow the instructions above ☝🏼

@jefferycline1
Copy link

Yes sir I would be honored

@jefferycline1
Copy link

@@

@gr2m
Copy link
Contributor

gr2m commented Oct 21, 2020

Please go ahead @jefferycline1. Let us know if you have any questions

@jefferycline1
Copy link

@@ -32,11 +32,11 @@ For other GitHub authentication strategies see [octokit/auth.js](https://github.
Browsers

-Load @octokit/auth-app directly from cdn.pika.dev
+Load @octokit/auth-app directly from cdn.skypack.dev

<script type="module">
-  import { createAppAuth } from "https://cdn.pika.dev/@octokit/auth-app";
+  import { createAppAuth } from "https://cdn.skypack.dev/@octokit/auth-app";
</script>

@gr2m
Copy link
Contributor

gr2m commented Oct 21, 2020

That's not how you send a pull request. The easiest way is to edit the README.md file directly in the browser, see the instructions in the issue. Here is the documentation on how to edit files directly in the browser: https://docs.github.com/en/free-pro-team@latest/github/managing-files-in-a-repository/editing-files-in-your-repository

This is the file you want to edit: https://github.com/octokit/auth-app.js/blob/master/README.md

@gr2m gr2m linked a pull request Oct 23, 2020 that will close this issue
@YubaNeupane
Copy link

Hey! can you let me fix this issue?

@gr2m
Copy link
Contributor

gr2m commented Nov 1, 2020

Sure thing πŸ‘πŸΌ

@gr2m gr2m linked a pull request Nov 1, 2020 that will close this issue
@gr2m gr2m closed this as completed in 783992b Nov 1, 2020
JS automation moved this from Bugs to Done Nov 1, 2020
@gr2m gr2m mentioned this issue Nov 1, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

πŸŽ‰ This issue has been resolved in version 2.10.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented, or is being fixed
Projects
No open projects
JS
  
Done
6 participants