Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw helpful error when appId or privateKey is set to a falsy value #280

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Apr 22, 2021

fixes #184

@gr2m gr2m added the Type: Feature New feature or request label Apr 22, 2021
@ghost ghost added this to Inbox in JS Apr 22, 2021
@ghost ghost moved this from Inbox to Features in JS Apr 22, 2021
@gr2m gr2m merged commit ee7b247 into master Apr 22, 2021
JS automation moved this from Features to Done Apr 22, 2021
@gr2m gr2m deleted the 184/throw-error-when-appId-is-set-to-falsy-value branch April 22, 2021 16:59
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@billyvg
Copy link

billyvg commented Dec 2, 2021

Just a note that this was a breaking change for us as we were instantiating a client intentionally with auth && privateKey && !installationId, which we use to call apps.getOrgInstallation to get the installationId to create a new client for that org. We now have to have to make sure the installationId property is not in the auth object if it's undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

Cannot authenticate with token or use "installation" method
2 participants