Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Cache#get type doesn't allow promises #556

Closed
1 task done
Mause opened this issue Dec 16, 2023 · 2 comments · Fixed by #557
Closed
1 task done

[BUG]: Cache#get type doesn't allow promises #556

Mause opened this issue Dec 16, 2023 · 2 comments · Fixed by #557
Labels
released Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented, or is being fixed

Comments

@Mause
Copy link
Contributor

Mause commented Dec 16, 2023

What happened?

Cache#get typescript type doesn't allow for a promise return type. The underlying code awaits the method fine though

Versions

Octokit auth app: 6.0.1
Typescript: 5.3.3
NodeJS: 18.16.1

Relevant log output

Type 'Promise<string | null>' is not assignable to type 'string'.

16     get(key: string) {
       ~~~

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Mause Mause added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented, or is being fixed labels Dec 16, 2023
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Contributor

🎉 This issue has been resolved in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented, or is being fixed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant