Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double requests when retrieving a new token #35

Closed
gr2m opened this issue Feb 18, 2020 · 1 comment · Fixed by #37
Closed

Avoid double requests when retrieving a new token #35

gr2m opened this issue Feb 18, 2020 · 1 comment · Fixed by #37
Assignees
@gr2m

Comments

@gr2m
Copy link
Contributor

gr2m commented Feb 18, 2020

When using with Octokit, the request strategy option will be set to octokit.request. octokit.request has also the hook from auth.hook.

When doing octokit.auth({ type: 'token', code }), the request to exchange the code for a token would be sent twice, because of auth.hook. That should not happen.
@gr2m gr2m added the bug label Feb 18, 2020
@gr2m gr2m self-assigned this Feb 18, 2020
@gr2m gr2m changed the title Avoid double interception requests to retrieve a new token. Avoid double requests when retrieving a new token Feb 18, 2020
@gr2m gr2m mentioned this issue Feb 18, 2020
Merged
@gr2m gr2m closed this as completed in #37 Feb 18, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Feb 18, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gr2m gr2m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid double requests when retrieving a new token octokit/auth-oauth-app.js
1 participant
@gr2m