Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

routes.json: add child team list route #664

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Conversation

nickvanw
Copy link

Hello 馃憢!

I was looking do some work with the GitHub API with regards to child teams, and I noticed that this route (thus, the accompanying method) seemed to be missing!

It's present in the hellcat preview definition here, so it should work with just these changes.

This is my first contribution to this project, so I'm not sure what the culture is around testing and examples? Let me know if there's anything else that needs to be done to get this merge-ready 馃槃.

@gr2m
Copy link
Contributor

gr2m commented Nov 29, 2017

Hello @nickvanw, thanks for the PR, it looks just right 馃憣

You can follow all important updates of node-github at #620. We are nearly done with the "maintainability" milestone, after which I plan to take an inventory, because there are other methods currently missing. But no reason to make you wait, I鈥檒l merge it in as is, it will get released automatically in am oment

@gr2m gr2m merged commit 14f18c2 into octokit:master Nov 29, 2017
@gr2m
Copy link
Contributor

gr2m commented Nov 29, 2017

released as v12.1.0

@nickvanw
Copy link
Author

You can follow all important updates of node-github at #620. We are nearly done with the "maintainability" milestone, after which I plan to take an inventory, because there are other methods currently missing.

Fantastic! Thanks for pointing me over there, and thanks for not making me wait 馃榿!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants