Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression introduced in v3.6.3 #308

Closed
wolfy1339 opened this issue Jul 8, 2022 · 2 comments
Closed

Regression introduced in v3.6.3 #308

wolfy1339 opened this issue Jul 8, 2022 · 2 comments
Labels
Type: Bug Something isn't working as documented
Projects

Comments

@wolfy1339
Copy link
Member

What happened?

While upgrading the dependency in octokit/app.js#306 due to the dropping of NodeJS v10 and v12 support, the tests failed
What did you expect to happen?

The tests to not have failed

What the problem might be

The regression was introduced by #288

/cc @baoshan

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jul 8, 2022
@ghost ghost added this to Bugs in JS Jul 8, 2022
@wolfy1339
Copy link
Member Author

We can publish a revert to both v4 and v3

@wolfy1339 Do you know what was the expected output here? #288
a) Get rid of state property
b) Make state property optional (only pass it if defined)

Originally posted by @oscard0m in octokit/app.js#306 (comment)

@wolfy1339 wolfy1339 changed the title Regression introduced in v2.6.3 Regression introduced in v3.6.3 Jul 8, 2022
@baoshan
Copy link
Contributor

baoshan commented Jul 8, 2022

Please see my preliminary thoughts on #309.

JS automation moved this from Bugs to Done Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
No open projects
JS
  
Done
Development

No branches or pull requests

2 participants