Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How soon are you pushing 0.1.0? #24

Closed
niftylettuce opened this issue Apr 5, 2012 · 14 comments
Closed

How soon are you pushing 0.1.0? #24

niftylettuce opened this issue Apr 5, 2012 · 14 comments

Comments

@niftylettuce
Copy link

No description provided.

@niftylettuce
Copy link
Author

oh it seems you're moving everything to https://github.com/c9/node-github3

@mikedeboer
Copy link

nope, it's the other way around in fact!

@niftylettuce
Copy link
Author

ah lol, so its now:

var GitHubApi = require('node-github');
var github = new GitHubApi({ version: '3.0.0' });

right?

@mikedeboer
Copy link

yes, indeed! There are some API incompatibilities between the two versions, but they are easy to spot.
Docs will appear on http://ajaxorg.github.com/node-github very shortly (I just pushed 'em).

@niftylettuce
Copy link
Author

what about authenticateToken ?

@niftylettuce
Copy link
Author

nvm

github.authenticate({
    type: "basic",
    username: username,
    password: password
});
github.user.update({
    location: "Argentina"
}, function(err) {
    console.log("done!");
});

@mikedeboer
Copy link

I added more examples there for you - and all others with the same question, of course ;)

@niftylettuce
Copy link
Author

authenticate({ type: 'token' }) doesn't seem to be working when passing a valid username and token option, returns 401, could you test?

@niftylettuce
Copy link
Author

oh nevermind, i still had user.update(username, {} vs user.update({}

@niftylettuce
Copy link
Author

hmm, still seems that token type is not working, getting 401 bad credentials.

@mikedeboer
Copy link

please read the README, I added a comment to the code example.

@niftylettuce
Copy link
Author

Github isn't supporting token auth it seems in v3 with username/token combination, only basic or oauth2

http://developer.github.com/v3/#authentication

we should remove the token auth type

@niftylettuce
Copy link
Author

ah I see your comment now, it wasn't there when I checked a bit ago :)

@niftylettuce
Copy link
Author

nice work, closing this issue

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants