Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github.repos.uploadAsset(options): replace options.filePath with options.file #638

Closed
gr2m opened this issue Oct 26, 2017 · 1 comment 路 Fixed by #629
Closed

github.repos.uploadAsset(options): replace options.filePath with options.file #638

gr2m opened this issue Oct 26, 2017 · 1 comment 路 Fixed by #629
Assignees
@gr2m
Milestone
v13.0.0 - Maintai...

Comments

@gr2m
Copy link
Contributor

gr2m commented Oct 26, 2017

This is one attempt at addressing #636

My goal is to drop dependency on fs and streams. Wish me luck 馃馃崁
@gr2m gr2m added this to the v13.0.0 - Maintainability milestone Oct 26, 2017
@gr2m gr2m self-assigned this Oct 26, 2017
This was referenced Oct 26, 2017
Closed
Closed
@gr2m
Copy link
Contributor Author

gr2m commented Nov 26, 2017

This is done via #640 and will be released in v13

@gr2m gr2m mentioned this issue Nov 26, 2017
Merged
@gr2m gr2m closed this as completed in #629 Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gr2m gr2m

Labels
None yet
Projects
None yet
Milestone
v13.0.0 - Maintainability
Development

Successfully merging a pull request may close this issue.

v13.0.0 - Maintainability octokit/octokit.js
1 participant
@gr2m