[BUG]: check_runs_for_check_suite generates invalid path if a repo string is passed in

[zrdaley]

What happened?

check_runs_for_check_suite accepts a repo name or id and then renders it to an API url using the path helper:

1. Repo name case ❌ :
   • result: repos/:repo_nwo/check-suites/:check_suite_id/check-runs
   • expected: /repos/{owner}/{repo}/check-runs/{check_run_id}
2. Repo ID case ✅ :
   • result: repositories/:repo_id/check-suites/:check_suite_id/check-runs
   • expected: same as above

Versions

gem "octokit", "~> 4.18.0"

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[DeepakRaj228]

Hi @nickfloyd and @zrdaley - I'm sorry, but I had difficulty understanding. Could you kindly clarify or provide more information? can you kindly explain what should be the expected one with the example?

I got values for both the endpoints which is mentioned

Repo name case ❌ :
current: repos/:repo_nwo/check-suites/:check_suite_id/check-runs
expected: /repos/{owner}/{repo}/check-runs/{check_run_id}

should it return list of all the check_run_ids from the check_suite from the expected endpoint?

1. current(/check-suites/#{id}/check-runs) behaviour returns details of the check_suites

2. Expected path which is mentioned /check-runs/{check_run_id} returns details of the check run but, we should pass the check_run_id instrad of check_suite_id