Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT]: Extend TooManyRequests test to check that the error message still differentiates between primary & secondary rate limits. #1590

Closed
1 task done
arjitj2 opened this issue Jul 7, 2023 · 0 comments · Fixed by #1591
Closed
1 task done

[MAINT]: Extend TooManyRequests test to check that the error message still differentiates between primary & secondary rate limits. #1590

arjitj2 opened this issue Jul 7, 2023 · 0 comments · Fixed by #1591
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@arjitj2
Copy link
Contributor

arjitj2 commented Jul 7, 2023

Describe the need

Both primary and secondary API rate limits raise the same Octokit::TooManyRequests error.

I would prefer for 2 separate errors to be raised, but if they're going to be the same, I'd like an additional regex check to make sure the error messages are being transparently passed through in the error.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@arjitj2 arjitj2 added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Jul 7, 2023
@arjitj2 arjitj2 mentioned this issue Jul 7, 2023
Merged
5 tasks
@kfcampbell kfcampbell added Priority: Normal and removed Status: Triage This is being looked at and prioritized labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
2 participants
@kfcampbell @arjitj2