More consistent formatting of requests in Client

lib/octokit/client/authorizations.rb

@@ -14,7 +14,7 @@ module Authorizations
       #  client = Octokit::Client.new(:login => 'ctshryock', :password => 'secret')
       #  client.authorizations
       def authorizations(options={})
-        get 'authorizations', options
+        get('authorizations', options)
       end
 
 
@@ -29,7 +29,7 @@ def authorizations(options={})
       #  client = Octokit::Client.new(:login => 'ctshryock', :password => 'secret')
       #  client.authorization(999999)
       def authorization(number, options={})
-        get "authorizations/#{number}", options
+        get("authorizations/#{number}", options)
       end
 
       # Create an authorization for the authenticated user.

lib/octokit/client/commits.rb

@@ -14,8 +14,7 @@ module Commits
       # @return [Array] An array of hashes representing commits
       # @see http://developer.github.com/v3/repos/commits/
       def commits(repo, sha_or_branch="master", options={})
-        params = { :sha => sha_or_branch, :per_page => 35 }
-        get("repos/#{Repository.new(repo)}/commits", params.merge(options))
+        get("repos/#{Repository.new(repo)}/commits", options.merge({ :sha => sha_or_branch, :per_page => 35 }))
       end
       alias :list_commits :commits
 
@@ -49,9 +48,12 @@ def commit(repo, sha, options={})
       #   commit.message # => "My commit message"
       #   commit.committer # => { "name" => "Wynn Netherland", "email" => "wynn@github.com", ... }
       def create_commit(repo, message, tree, parents=nil, options={})
-        params = { :message => message, :tree => tree }
-        params[:parents] = [parents].flatten if parents
-        post("repos/#{Repository.new(repo)}/git/commits", options.merge(params))
+        options.merge!({
+          :message => message,
+          :tree => tree
+        })
+        options[:parents] = [parents].flatten if parents
+        post("repos/#{Repository.new(repo)}/git/commits", options)
       end
 
       # List all commit comments
@@ -101,14 +103,14 @@ def commit_comment(repo, id, options={})
       #   commit.line # => 10
       #   commit.position # => 1
       def create_commit_comment(repo, sha, body, path=nil, line=nil, position=nil, options={})
-        params = {
+        options.merge!({
           :body => body,
           :commit_id => sha,
           :path => path,
           :line => line,
           :position => position
-        }
-        post("repos/#{Repository.new(repo)}/commits/#{sha}/comments", options.merge(params))
+        })
+        post("repos/#{Repository.new(repo)}/commits/#{sha}/comments", options)
       end
 
       # Update a commit comment
@@ -123,10 +125,7 @@ def create_commit_comment(repo, sha, body, path=nil, line=nil, position=nil, opt
       #   commit.id # => 860296
       #   commit.body # => "Updated commit comment"
       def update_commit_comment(repo, id, body, options={})
-        params = {
-          :body => body
-        }
-        patch("repos/#{Repository.new(repo)}/comments/#{id}", options.merge(params))
+        patch("repos/#{Repository.new(repo)}/comments/#{id}", options.merge({:body => body}))
       end
 
       # Delete a commit comment
@@ -159,11 +158,11 @@ def compare(repo, start, endd, options={})
       # @return [Hashie::Mash] A hash representing the comparison
       # @see http://developer.github.com/v3/repos/merging/
       def merge(repo, base, head, options={})
-        params = {
+         options.merge!({
           :base => base,
           :head => head
-        }.merge(options)
-        post("repos/#{Repository.new(repo)}/merges", params)
+        })
+        post("repos/#{Repository.new(repo)}/merges", options)
       end
 
       # Get commits based on time windows
@@ -178,8 +177,7 @@ def merge(repo, base, head, options={})
       # @example
       #   Octokit.commits_since('pengwynn/octokit', '2012-10-01')
       def commits_since(repo, date, sha_or_branch="master", options={})
-        params = {:since => iso8601(parse_date(date))}
-        commits(repo, sha_or_branch, params.merge(options))
+        commits(repo, sha_or_branch, options.merge({:since => iso8601(parse_date(date))}))
       end
 
       # Get commits before a specified date
@@ -192,8 +190,7 @@ def commits_since(repo, date, sha_or_branch="master", options={})
       # @example
       #   Octokit.commits_before('pengwynn/octokit', '2012-10-01')
       def commits_before(repo, date, sha_or_branch="master", options={})
-        params = {:until => iso8601(parse_date(date))}
-        commits(repo, sha_or_branch, params.merge(options))
+        commits(repo, sha_or_branch, options.merge({:until => iso8601(parse_date(date))}))
       end
 
       # Get commits on a specified date
@@ -214,8 +211,11 @@ def commits_on(repo, date, sha_or_branch="master", options={})
         rescue ArgumentError
           raise ArgumentError, "#{date} is not a valid date"
         end
-        params = { :since => iso8601(start_date), :until => iso8601(end_date) }
-        commits(repo, sha_or_branch, params.merge(options))
+        options.merge!({
+          :since => iso8601(start_date), 
+          :until => iso8601(end_date)
+        })
+        commits(repo, sha_or_branch, options)
       end
 
       # Get commits made between two nominated dates
@@ -246,9 +246,11 @@ def commits_between(repo, start_date, end_date, sha_or_branch="master", options=
         if _end_date < _start_date
           raise ArgumentError, "Start date #{start_date} does not precede #{end_date}"
         end
-        params = {:since => iso8601(_start_date),
-          :until => iso8601(_end_date) }
-        commits(repo, sha_or_branch, params.merge(options))
+        options.merge!({
+          :since => iso8601(_start_date),
+          :until => iso8601(_end_date)
+        })
+        commits(repo, sha_or_branch, options)
       end
 
       protected

lib/octokit/client/emojis.rb

@@ -7,7 +7,7 @@ module Emojis
       # @example List all emojis
       #   Octokit.emojis
       def emojis
-        get "emojis"
+        get("emojis")
       end
     end
   end

lib/octokit/client/gists.rb

@@ -13,9 +13,9 @@ module Gists
       # @see http://developer.github.com/v3/gists/#list-gists
       def gists(username=nil, options={})
         if username.nil?
-          get 'gists', options
+          get('gists', options)
         else
-          get "users/#{username}/gists", options
+          get("users/#{username}/gists", options)
         end
       end
       alias :list_gists :gists
@@ -27,14 +27,14 @@ def gists(username=nil, options={})
       #   Octokit.public_gists
       # @see http://developer.github.com/v3/gists/#list-gists
       def public_gists(options={})
-        get 'gists/public', options
+        get('gists/public', options)
       end
 
       # List the authenticated user’s starred gists
       #
       # @return [Array<Hashie::Mash>] A list of gists
       def starred_gists(options={})
-        get 'gists/starred', options
+        get('gists/starred', options)
       end
 
       # Get a single gist
@@ -43,7 +43,7 @@ def starred_gists(options={})
       # @return [Hash::Mash] Gist information
       # @see http://developer.github.com/v3/gists/#get-a-single-gist
       def gist(gist, options={})
-        get "gists/#{Gist.new gist}", options
+        get("gists/#{Gist.new gist}", options)
       end
 
       # Create a gist
@@ -57,7 +57,7 @@ def gist(gist, options={})
       # @return [Hashie::Mash] Newly created gist info
       # @see http://developer.github.com/v3/gists/#create-a-gist
       def create_gist(options={})
-        post 'gists', options
+        post('gists', options)
       end
 
       # Edit a gist
@@ -76,7 +76,7 @@ def create_gist(options={})
       #   [Hashie::Mash] Newly created gist info
       # @see http://developer.github.com/v3/gists/#edit-a-gist
       def edit_gist(gist, options={})
-        patch "gists/#{Gist.new gist}", options
+        patch("gists/#{Gist.new gist}", options)
       end
 
       #
@@ -113,7 +113,7 @@ def gist_starred?(gist, options={})
       # @return [Hashie::Mash] Data for the new gist
       # @see http://developer.github.com/v3/gists/#fork-a-gist
       def fork_gist(gist, options={})
-        post "gists/#{Gist.new gist}/forks", options
+        post("gists/#{Gist.new gist}/forks", options)
       end
 
       # Delete a gist
@@ -133,7 +133,7 @@ def delete_gist(gist, options={})
       # @example
       #   Octokit.gist_comments('3528ae645')
       def gist_comments(gist_id, options={})
-        get "gists/#{gist_id}/comments", options
+        get("gists/#{gist_id}/comments", options)
       end
 
       # Get gist comment
@@ -145,7 +145,7 @@ def gist_comments(gist_id, options={})
       # @example
       #   Octokit.gist_comment('208sdaz3', 1451398)
       def gist_comment(gist_id, gist_comment_id, options={})
-        get "gists/#{gist_id}/comments/#{gist_comment_id}", options
+        get("gists/#{gist_id}/comments/#{gist_comment_id}", options)
       end
 
       # Create gist comment
@@ -160,8 +160,7 @@ def gist_comment(gist_id, gist_comment_id, options={})
       # @example
       #   @client.create_gist_comment('3528645', 'This is very helpful.')
       def create_gist_comment(gist_id, comment, options={})
-        options.merge!({:body => comment})
-        post "gists/#{gist_id}/comments", options
+        post("gists/#{gist_id}/comments", options.merge({:body => comment}))
       end
 
       # Update gist comment
@@ -177,8 +176,7 @@ def create_gist_comment(gist_id, comment, options={})
       # @example
       #   @client.update_gist_comment('208sdaz3', '3528645', ':heart:')
       def update_gist_comment(gist_id, gist_comment_id, comment, options={})
-        options.merge!({:body => comment})
-        patch "gists/#{gist_id}/comments/#{gist_comment_id}", options
+        patch("gists/#{gist_id}/comments/#{gist_comment_id}", options.merge({:body => comment}))
       end
 
       # Delete gist comment

lib/octokit/client/github.rb

@@ -11,7 +11,7 @@ module GitHub
       # @example Get GitHub meta information
       #   @client.github_meta
       def github_meta(options={})
-        get "/meta", options
+        get("/meta", options)
       end
 
     end

lib/octokit/client/gitignore.rb

@@ -14,7 +14,7 @@ module Gitignore
       # @example Git all the gitignore templates
       #   @client.gitignore_templates
       def gitignore_templates(options={})
-        get "/gitignore/templates", options
+        get("/gitignore/templates", options)
       end
 
       # Get a gitignore template.
@@ -33,7 +33,7 @@ def gitignore_templates(options={})
       # @example Get the Ruby gitignore template
       #   @client.gitignore_template('Ruby')
       def gitignore_template(template_name, options={})
-        get "/gitignore/templates/#{template_name}", options
+        get("/gitignore/templates/#{template_name}", options)
       end
 
     end

lib/octokit/client/issues.rb

@@ -139,7 +139,7 @@ def update_issue(repo, number, title, body, options={})
       #     :since => '2010-05-04T23:45:02Z'
       #   })
       def issues_comments(repo, options={})
-        get "/repos/#{Repository.new repo}/issues/comments", options
+        get("/repos/#{Repository.new repo}/issues/comments", options)
       end
 
       # Get all comments attached to an issue

lib/octokit/client/objects.rb

@@ -32,8 +32,7 @@ def tree(repo, tree_sha, options={})
       #   tree.sha # => "cd8274d15fa3ae2ab983129fb037999f264ba9a7"
       #   tree.tree.first.path # => "file.rb"
       def create_tree(repo, tree, options={})
-        parameters = { :tree => tree }
-        post("repos/#{Repository.new(repo)}/git/trees", options.merge(parameters))
+        post("repos/#{Repository.new(repo)}/git/trees", options.merge({:tree => tree}))
       end
 
       # Get a single blob, fetching its content and encoding
@@ -69,11 +68,11 @@ def blob(repo, blob_sha, options={})
       #   require "base64"
       #   Octokit.create_blob("octocat/Hello-World", Base64.encode64("foo bar baz"), "base64")
       def create_blob(repo, content, encoding="utf-8", options={})
-        parameters = {
+        options.merge!({
           :content => content,
           :encoding => encoding
-        }
-        post("repos/#{Repository.new(repo)}/git/blobs", options.merge(parameters)).sha
+        })
+        post("repos/#{Repository.new(repo)}/git/blobs", options).sha
       end
 
       # Get a tag

lib/octokit/client/organizations.rb

@@ -366,7 +366,7 @@ def team_repositories(team_id, options={})
       # @example
       #   @client.add_team_repo(100000, 'github/developer.github.com')
       def add_team_repository(team_id, repo, options={})
-        boolean_from_response(:put, "teams/#{team_id}/repos/#{Repository.new(repo)}", options.merge(:name => Repository.new(repo)))
+        boolean_from_response(:put, "teams/#{team_id}/repos/#{Repository.new(repo)}", options.merge({:name => Repository.new(repo)}))
       end
       alias :add_team_repo :add_team_repository
 

lib/octokit/client/refs.rb

@@ -40,11 +40,11 @@ def ref(repo, ref, options={})
       # @example Create refs/heads/master for octocat/Hello-World with sha 827efc6d56897b048c772eb4087f854f46256132
       #   Octokit.create_ref("octocat/Hello-World","heads/master", "827efc6d56897b048c772eb4087f854f46256132")
       def create_ref(repo, ref, sha, options={})
-        parameters = {
+        options.merge!({
           :ref  => "refs/#{ref}",
           :sha  => sha
-        }
-        post("repos/#{Repository.new(repo)}/git/refs", options.merge(parameters))
+        })
+        post("repos/#{Repository.new(repo)}/git/refs", options)
       end
       alias :create_reference :create_ref
 
@@ -59,11 +59,11 @@ def create_ref(repo, ref, sha, options={})
       # @example Force update heads/sc/featureA for octocat/Hello-World with sha aa218f56b14c9653891f9e74264a383fa43fefbd
       #   Octokit.update_ref("octocat/Hello-World","heads/sc/featureA", "aa218f56b14c9653891f9e74264a383fa43fefbd")
       def update_ref(repo, ref, sha, force=true, options={})
-        parameters = {
+        options.merge!({
           :sha  => sha,
           :force => force
-        }
-        patch("repos/#{Repository.new(repo)}/git/refs/#{ref}", options.merge(parameters))
+        })
+        patch("repos/#{Repository.new(repo)}/git/refs/#{ref}", options)
       end
       alias :update_reference :update_ref