BREAKING CHANGE: deprecate GHES 3.2 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octokitbot
added
Type: Maintenance
ghost
added this to Inbox
in 
wolfy1339
added
the
Status: Blocked
wolfy1339
previously requested changes
Jan 18, 2023
wolfy1339
force-pushed
the
openapi-update
branch
from
344003d
to
e97d9d0
Compare
wolfy1339
removed
the
Status: Blocked
|
@wolfy1339 since this is a breaking change with the deprecation of GHES 3.2 and the PR description says to "avoid breaking changes at all costs", what's the correct path forward here? |
wolfy1339
added
the
Type: Breaking change
|
In cases like these where support is removed for a GHES version, a major version bump is unavoidable. |
kfcampbell
changed the title
kfcampbell
approved these changes
Jan 19, 2023
|
BREAKING CHANGE should be in the commit body commit message, like so:
that way we can have a better idea of the changes in the changelog and commit history |
|
🎉 This PR is included in version 15.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.
In general
build: cacheas commit messagefix: ...feat: ...BREAKING CHANGE: ...to the commit body (not subject!) to trigger a breaking change.