Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @octokit/core as peerDependency #221

Closed
gr2m opened this issue Aug 26, 2020 · 1 comment · Fixed by #274
Closed

Add @octokit/core as peerDependency #221

gr2m opened this issue Aug 26, 2020 · 1 comment · Fixed by #274
Projects

Comments

@gr2m
Copy link
Contributor

gr2m commented Aug 26, 2020

This is a follow up issue to octokit/plugin-paginate-rest.js#124 (comment)

We need to add @octokit/core as a peerDependency to address a problem with yarn 2. It is something I planned to do anyway, but wanted to figure out automated testing to assure compatibility of the plugins with the latest @octokit/core.

I only want to define compatibility with the lowest version, in this case v3. Compare pull request https://github.com/octokit/plugin-paginate-rest.js/pull/130/files.

I would appreciate help, this is a great issue for a first-time contributor

@ghost ghost added this to Inbox in JS Aug 26, 2020
@gr2m gr2m added the bug label Sep 10, 2020
@ghost ghost moved this from Inbox to Bugs in JS Sep 10, 2020
@gr2m gr2m linked a pull request Oct 19, 2020 that will close this issue
@gr2m gr2m removed a link to a pull request Oct 24, 2020
@gr2m gr2m closed this as completed in #274 Oct 26, 2020
JS automation moved this from Bugs to Done Oct 26, 2020
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 9.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
JS
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant