Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly mark type imports and exports #540

Merged
merged 1 commit into from Jun 14, 2023

Conversation

wolfy1339
Copy link
Member

Resolves #ISSUE_NUMBER


Behavior

Before the change?

  • The build would fail since the types weren't marked explicitly

After the change?

  • The build now passes again

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jun 14, 2023
@ghost ghost added this to Bugs in JS Jun 14, 2023
@wolfy1339 wolfy1339 merged commit b943e50 into main Jun 14, 2023
9 checks passed
@wolfy1339 wolfy1339 deleted the fix-type-imports/exports branch June 14, 2023 23:47
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
JS
  
Bugs
Development

Successfully merging this pull request may close these issues.

None yet

2 participants