Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new /orgs/{org}/actions/runners/generate-jitconfig endpoint, and documentation updates #645

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

octokitbot
Copy link
Collaborator

If there are any new endpoints, then the code changes will likely required an update of @octokit/types. It should have received a pull request as well, merge & release it first. The @octokit/types should be updated automatically shortly after in this pull request.

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript or code changes, use a docs prefix
  • If there are typescript changes but no code changes, use fix(typescript) prefix
  • If there are code changes, use fix if a problem was resolved, feat if new endpoints / parameters were added, and feat(deprecation) if a method was deprecated.

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 9, 2023
@ghost ghost added this to Inbox in JS Jun 9, 2023
@ghost ghost moved this from Inbox to Maintenance in JS Jun 9, 2023
@wolfy1339 wolfy1339 changed the title 🚧 GitHub OpenAPI specifications changed feat: new /orgs/{org}/actions/runners/generate-jitconfig endpoint, and documentation updates Jun 9, 2023
@wolfy1339 wolfy1339 merged commit e94662f into main Jun 9, 2023
9 checks passed
@wolfy1339 wolfy1339 deleted the openapi-update branch June 9, 2023 18:28
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Jason3S
Copy link

Jason3S commented Jun 10, 2023

@wolfy1339,

7.2.0 seems to have broken things.

image

@wolfy1339
Copy link
Member

I noticed this in another package. It's odd how this one didn't error in any of the tests.
I do have a fix in the works: octokit/types.ts#555

@Jason3S
Copy link

Jason3S commented Jun 11, 2023

@wolfy1339,

Thank you. Your fix worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
JS
  
Maintenance
Development

Successfully merging this pull request may close these issues.

None yet

3 participants