Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(release): use OCTOKITBOT_PAT as GITHUB_TOKEN #159

Merged
merged 1 commit into from
Jul 9, 2022
Merged

ci(release): use OCTOKITBOT_PAT as GITHUB_TOKEN #159

merged 1 commit into from
Jul 9, 2022

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Jul 9, 2022

Fix #158

@ghost ghost added this to Inbox in JS Jul 9, 2022
@ghost ghost moved this from Inbox to Maintenance in JS Jul 9, 2022
@oscard0m oscard0m requested a review from gr2m July 9, 2022 21:07
@gr2m gr2m merged commit 92d8e64 into master Jul 9, 2022
JS automation moved this from Maintenance to Done Jul 9, 2022
@gr2m gr2m deleted the oscard0m-patch-1 branch July 9, 2022 21:16
@gr2m
Copy link
Contributor

gr2m commented Jul 9, 2022

I changed the commit to fix(... to test if the setup works

@gr2m
Copy link
Contributor

gr2m commented Jul 9, 2022

hmm that failed 🤔

@oscard0m
Copy link
Member Author

oscard0m commented Jul 9, 2022

hmm that failed 🤔

is ${{ secrets.OCTOKITBOT_PAT }} for this repository already?

@gr2m
Copy link
Contributor

gr2m commented Jul 9, 2022

Yes OCTOKITBOT_PAT is set for all @octokit repositories

@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 2.1.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gr2m
Copy link
Contributor

gr2m commented Jul 9, 2022

okay, we have to pass the PAT to the actions/checkout step as well, this article reminded me of that:
https://www.paulmowat.co.uk/blog/resolve-github-action-gh006-protected-branch-update-failed

      - uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3
        with:
          token: ${{ secrets.OCTOKITBOT_PAT }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PRs are mergeable with check runs failing and no approvals in this repository
3 participants
@oscard0m @gr2m @octokitbot