Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

> I see some repositories using npm run build #259

Closed
najmulsheik opened this issue Jul 23, 2023 · 1 comment
Closed

> I see some repositories using npm run build #259

najmulsheik opened this issue Jul 23, 2023 · 1 comment
Projects

Comments

@najmulsheik
Copy link

          > I see some repositories using `npm run build`

I'd always run it with npm run build --if-present, just like the others. This makes sure that we verify that the dependencies only used for building are tested as part of the CI

  • npm run validate:ts
  • npm run test:typescript
  • npm run test:ts

I'm tending towards test:tsc to be as clear as possible. In other project I use test:tsd for type-only tests using tsd, and in future when I hope me move away from TS source code I could imagine @octokit to use that, too (Example)

But I'm open to anything, it's not set in stone. I do agree we should normalize it across the @octokit repositories though

Originally posted by @gr2m in octokit/.github#13 (comment)

@ghost ghost added this to Inbox in JS Jul 23, 2023
@kfcampbell
Copy link
Member

This seems off-topic/potentially spam, closing for that reason.

@kfcampbell kfcampbell closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
JS
  
Inbox
Development

No branches or pull requests

2 participants