fix: pass parsed options into request

this should be a refactor but @ocotkit/rest uses these internals
octokit · Oct 31, 2018 · f57f14a · f57f14a
1 parent 555b831
commit f57f14a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/request.js b/lib/request.js
@@ -8,9 +8,7 @@ const mockable = require('./fetch')
 const getBuffer = require('./get-buffer-response')
 const HttpError = require('./http-error')
 
-function request (endpoint, route, options) {
-  const requestOptions = endpoint(route, options)
-
+function request (requestOptions) {
   if (isPlainObject(requestOptions.body) || Array.isArray(requestOptions.body)) {
     requestOptions.body = JSON.stringify(requestOptions.body)
   }

diff --git a/lib/with-defaults.js b/lib/with-defaults.js
@@ -4,7 +4,10 @@ const request = require('./request')
 
 function withDefaults (oldEndpoint, newDefaults) {
   const endpoint = oldEndpoint.defaults(newDefaults)
-  const newApi = request.bind(null, endpoint)
+  const newApi = function (route, options) {
+    return request(endpoint(route, options))
+  }
+
   newApi.endpoint = endpoint
   newApi.defaults = withDefaults.bind(null, endpoint)
   return newApi