Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to ESM output #678

Merged
merged 11 commits into from
Feb 24, 2024
Merged

feat: switch to ESM output #678

merged 11 commits into from
Feb 24, 2024

Conversation

wolfy1339
Copy link
Member

BREAKING CHANGE: Output a single ESM bundle

@wolfy1339
feat: switch to ESM output
8df344f 
BREAKING CHANGE: Output a single ESM bundle
@wolfy1339 wolfy1339 added Type: Feature New feature or request Type: Breaking change Used to note any change that requires a major version bump labels Feb 23, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member Author

The types for the Fetch API don't allow headers to be passed as numbers, only as string. The docs also mention this https://developer.mozilla.org/en-US/docs/Web/API/Headers/Headers#init

I added a conversion since we accept numbers

@wolfy1339
Copy link
Member Author

There's some funkyness going on with fetch-mock... It's complaining about "Unmatched GET"/ "No fallback response defined for GET to [..]"

@wolfy1339
maint(fetch-wrapper): transform headers back into an Object
6de06fb 
This fixes the tests, as we are expecting an Object in the fetch-mock matcher functions
@wolfy1339 wolfy1339 merged commit 517fd98 into main Feb 24, 2024
8 checks passed
@wolfy1339 wolfy1339 deleted the beta branch February 24, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wolfy1339 @gr2m