fix: correctly upload asset if file is Buffer/ArrayBuffer

octokit · Jan 27, 2018 · d191dfc · d191dfc
1 parent e16817d
commit d191dfc
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/request/request.js b/lib/request/request.js
@@ -8,6 +8,7 @@ const https = require('https')
 
 const _ = require('lodash')
 const debug = require('debug')('octokit:rest')
+const isArrayBuffer = require('is-array-buffer')
 const isStream = require('is-stream')
 
 const errors = require('./errors')
@@ -22,7 +23,8 @@ function httpRequest (requestOptions) {
   // calculate content length unless body is a stream, in which case the
   // content length is already set per option
   if (requestOptions.body && !isStream(requestOptions.body)) {
-    if (typeof requestOptions.body !== 'string') {
+    // stringify body unless it’s an ArrayBuffer
+    if (!isArrayBuffer(requestOptions.body) && !Buffer.isBuffer(requestOptions.body) && typeof requestOptions.body !== 'string') {
       requestOptions.body = JSON.stringify(requestOptions.body)
     }