Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

fix: workaround for udpate-a-gist content definition #723

Merged
merged 3 commits into from
May 17, 2020
Merged

fix: workaround for udpate-a-gist content definition #723

merged 3 commits into from
May 17, 2020

Conversation

0x-jerry
Copy link
Contributor

fixes #718

@ghost ghost added this to Inbox in JS May 16, 2020
@0x-jerry 0x-jerry changed the title fix: workaround for udpate-a-gist content definition #718 fix: workaround for udpate-a-gist content definition May 16, 2020
@RomanHotsiy
Copy link
Collaborator

RomanHotsiy commented May 16, 2020

@cwxyz007 I've noticed there are a bunch of other places (mostly in response schemas) where gist files have an incorrect schema.

Here is the full list:

Could you also try to fix those in your PR too?

@0x-jerry
Copy link
Contributor Author

@RomanHotsiy I have fixed all the incorrect schema that you list above, but I have no idea how to fix the test :)

@RomanHotsiy RomanHotsiy requested a review from gr2m May 17, 2020 06:05
@gr2m gr2m added the bug Something isn't working as documented, or is being fixed label May 17, 2020
@ghost ghost moved this from Inbox to Bugs in JS May 17, 2020
@gr2m
Copy link
Contributor

gr2m commented May 17, 2020

Thanks @cwxyz007 & @RomanHotsiy

@gr2m gr2m merged commit a9c1aaa into octokit:master May 17, 2020
JS automation moved this from Bugs to Done May 17, 2020
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 28.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@octokitbot octokitbot added the released Released via semantic-release label May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working as documented, or is being fixed released Released via semantic-release
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

Incorrect files property in POST /gists
4 participants